[webkit-reviews] review granted: [Bug 171345] URLSearchParams should be reflective : [Attachment 308553] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 28 13:15:50 PDT 2017
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 171345: URLSearchParams should be reflective
https://bugs.webkit.org/show_bug.cgi?id=171345
Attachment 308553: Patch
https://bugs.webkit.org/attachment.cgi?id=308553&action=review
--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 308553
--> https://bugs.webkit.org/attachment.cgi?id=308553
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=308553&action=review
> Source/WebCore/platform/URLParser.cpp:2819
> + auto name = formURLDecode(bytes.toString().replace('+', 0x20));
We should make a StringView.replace that returns a String. This does an
unnecessary copy. Maybe in a followup.
More information about the webkit-reviews
mailing list