[webkit-reviews] review granted: [Bug 171434] [macOS] WebPlaybackControlsManager needs to know when the selected text or audio track changes : [Attachment 308578] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 171434: [macOS] WebPlaybackControlsManager needs to know when the selected
text or audio track changes
https://bugs.webkit.org/show_bug.cgi?id=171434

Attachment 308578: Patch

https://bugs.webkit.org/attachment.cgi?id=308578&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 308578
  --> https://bugs.webkit.org/attachment.cgi?id=308578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308578&action=review

> Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm:451
> +    if (offItem && !trackMenuItemSelected && displayMode ==
MediaControlsHost::forcedOnlyKeyword())

Nice catch!