[webkit-reviews] review granted: [Bug 171441] [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry : [Attachment 308564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 28 12:06:22 PDT 2017


Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 171441: [WebGPU] Label MTLCommandQueues with a prefix for internal
telemetry
https://bugs.webkit.org/show_bug.cgi?id=171441

Attachment 308564: Patch

https://bugs.webkit.org/attachment.cgi?id=308564&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 308564
  --> https://bugs.webkit.org/attachment.cgi?id=308564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308564&action=review

> Source/WebCore/platform/graphics/cocoa/GPUCommandQueueMetal.mm:61
> +    ASSERT([prefixedLabel length] >= ([webkitPrefix length] + 1));

Dots. Lots of dots.


More information about the webkit-reviews mailing list