[webkit-reviews] review granted: [Bug 171408] Teach WebProcessPool to track a map of SessionIDs to WebPageProxys to manage their lifetime : [Attachment 308503] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 171408: Teach WebProcessPool to track a map of SessionIDs to WebPageProxys
to manage their lifetime
https://bugs.webkit.org/show_bug.cgi?id=171408

Attachment 308503: Patch

https://bugs.webkit.org/attachment.cgi?id=308503&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 308503
  --> https://bugs.webkit.org/attachment.cgi?id=308503
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308503&action=review

> Source/WebKit2/UIProcess/WebProcessPool.cpp:954
> +	   // FIXME: Remove this ASSERT and change these messages once multiple
persistent sessions exist.
> +	   ASSERT(sessionID.isEphemeral());
> +	  
networkProcess()->send(Messages::NetworkProcess::DestroyPrivateBrowsingSession(
sessionID), 0);
> +	  
page.process().send(Messages::WebProcess::DestroyPrivateBrowsingSession(session
ID), 0);

I guess we'll also rename DestroyPrivateBrowsingSession to DestroySession,
right?

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:293
> +    auto removedPage = m_pageMap.take(pageID);

auto*