[webkit-reviews] review granted: [Bug 171404] Fix some RELEASE_ASSERT failures caused by OutOfMemoryErrors. : [Attachment 308484] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 27 18:07:41 PDT 2017

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 171404: Fix some RELEASE_ASSERT failures caused by OutOfMemoryErrors.

Attachment 308484: proposed patch.


--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 308484
  --> https://bugs.webkit.org/attachment.cgi?id=308484
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=308484&action=review

> Source/JavaScriptCore/runtime/JSCellInlines.h:146
> +template<typename T, AllocationFailureMode mode,
GCDeferralContextArgPresense deferralContextArgPresence>
> +void* tryAllocateCellHelper(Heap& heap, GCDeferralContext* deferralContext,
size_t size)

I would mark this as ALWAYS_INLINE

> Source/JavaScriptCore/runtime/JSFixedArray.h:47
>      ALWAYS_INLINE static JSFixedArray* createFromArray(ExecState* exec, VM&
vm, JSArray* array)
>      {

The caller of this from operationMaterializeObjectInOSR is not OK w/ returning
nullptr here. Please fix to make that release assert.

More information about the webkit-reviews mailing list