[webkit-reviews] review granted: [Bug 171402] Web Inspector: RTL: inherit system layout direction by default : [Attachment 308473] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 27 16:38:45 PDT 2017

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 171402: Web Inspector: RTL: inherit system layout direction by default

Attachment 308473: Patch


--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 308473
  --> https://bugs.webkit.org/attachment.cgi?id=308473

View in context: https://bugs.webkit.org/attachment.cgi?id=308473&action=review


> Source/WebInspectorUI/UserInterface/Base/Setting.js:115
> -    // FIXME: change initial value to 'system' once we are happy with RTL
> -    // This will cause Web Inspector to use the system user interface layout
> -    layoutDirection: new WebInspector.Setting("layout-direction", "ltr"),
> +    layoutDirectionOverride: new
WebInspector.Setting("layout-direction-override", "system"),

I realize the storage name needs to change in order for us to get the new
default value of "system" going forward.

However I think WebInspector.settings.layoutDirection is way better than
WebInspector.settings.layoutDirectionOverride. I suggest we keep that.

This brings to light that in the future we should name settings that are in
experimental stages with a storage name "...-experimental" so that when we turn
it on by default and rename it we can get the better name when it graduates!

More information about the webkit-reviews mailing list