[webkit-reviews] review granted: [Bug 171322] Align colspan/rowspan limits with the latest HTML specification : [Attachment 308421] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 27 15:43:11 PDT 2017


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171322: Align colspan/rowspan limits with the latest HTML specification
https://bugs.webkit.org/show_bug.cgi?id=171322

Attachment 308421: Patch

https://bugs.webkit.org/attachment.cgi?id=308421&action=review




--- Comment #18 from Darin Adler <darin at apple.com> ---
Comment on attachment 308421
  --> https://bugs.webkit.org/attachment.cgi?id=308421
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308421&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:157
> +static HTMLIntegerParsingError parseHTMLIntegerInternal(const CharacterType*
position, const CharacterType* end, int& result)

Should this use std::expected instead?


More information about the webkit-reviews mailing list