[webkit-reviews] review granted: [Bug 171384] bmalloc scavenger should know what page classes are allocating : [Attachment 308441] Updated patch addressing review comments

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 171384: bmalloc scavenger should know what page classes are allocating
https://bugs.webkit.org/show_bug.cgi?id=171384

Attachment 308441: Updated patch addressing review comments

https://bugs.webkit.org/attachment.cgi?id=308441&action=review




--- Comment #6 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 308441
  --> https://bugs.webkit.org/attachment.cgi?id=308441
Updated patch addressing review comments

View in context: https://bugs.webkit.org/attachment.cgi?id=308441&action=review

r=me

> Source/bmalloc/bmalloc/VMHeap.h:44
> +typedef enum { DeallocateSynchronously, DeallocateAsynchronously }
DeallocationMode;

This should be an enum class. Then you get better type safety and you don't
need to put the class name in the value names.

I'd call this "enum class { Sync, Async } ScavengeMode".