[webkit-reviews] review granted: [Bug 171362] Enhance shouldBe()/shouldNotBe() to accept anonymous function arguments : [Attachment 308432] Patch v2

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 171362: Enhance shouldBe()/shouldNotBe() to accept anonymous function
arguments
https://bugs.webkit.org/show_bug.cgi?id=171362

Attachment 308432: Patch v2

https://bugs.webkit.org/attachment.cgi?id=308432&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 308432
  --> https://bugs.webkit.org/attachment.cgi?id=308432
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=308432&action=review

r=me

These files seem to vary between 2 and 4 spaces indentation. You can fix if you
want, or leave mixed but eliminate the 3s =)

> LayoutTests/ChangeLog:43
> +	   to shoudlBe() into an anonymous function.

Typo: "shoudlBe"

> LayoutTests/http/tests/resources/js-test-pre.js:219
> +  try {
> +	_av = eval(_a);
> +  } catch (e) {

Style: indent is 3 instead of 2.

How did this file come to have 2 space indent anyways. Weird.

> LayoutTests/http/tests/resources/js-test-pre.js:647
> +	return _av.then(function(result) {

Style: whitespace is slightly off