[webkit-reviews] review canceled: [Bug 150358] Support for promise rejection events (unhandledrejection) : [Attachment 308325] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 150358: Support for promise rejection events (unhandledrejection)
https://bugs.webkit.org/show_bug.cgi?id=150358

Attachment 308325: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=308325&action=review




--- Comment #189 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 308325
  --> https://bugs.webkit.org/attachment.cgi?id=308325
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308325&action=review

> Source/WebCore/dom/RejectedPromiseTracker.cpp:121
> +    m_aboutToBeNotifiedRejectedPromises.append(UnhandledPromise { vm,
globalObject, promise, createScriptCallStackFromReason(state, reason) });

To Saam's point about only doing work where there is a debugger, we could avoid
capturing a call stack here unless there is a debugger.

Then, promise rejections would have a smaller impact for users that never open
developer tools.