[webkit-reviews] review granted: [Bug 170730] REGRESSION(r215211): [GTK] Several webgl related tests are failing : [Attachment 308372] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 27 11:26:28 PDT 2017

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 170730: REGRESSION(r215211): [GTK] Several webgl related tests are failing

Attachment 308372: Patch


--- Comment #24 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 308372
  --> https://bugs.webkit.org/attachment.cgi?id=308372

View in context: https://bugs.webkit.org/attachment.cgi?id=308372&action=review

> Source/WebCore/platform/image-decoders/ImageDecoder.h:73
> +    bool isAllDataReceived() const { return m_encodedDataStatus ==
EncodedDataStatus::Complete; }

Since setData() is the only place which sets m_encodedDataStatus to
EncodedDataStatus::Complete, I think we should enforce all the callee of
setData() to not call this function at least through an assertion in this

return m_encodedDataStatus == EncodedDataStatus::Complete;

Or something similar.

> Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:81
> +bool WEBPImageDecoder::decode(bool onlySize, bool allDataReceived)

I think we usually omit the argument if it is not used. It is okay to keep it
in the header file though especially with built-in types.
bool WEBPImageDecoder::decode(bool onlySize, bool)

More information about the webkit-reviews mailing list