[webkit-reviews] review granted: [Bug 171367] Refactor SessionID to support multiple non-ephemeral (persistent) sessions : [Attachment 308406] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 171367: Refactor SessionID to support multiple non-ephemeral (persistent)
sessions
https://bugs.webkit.org/show_bug.cgi?id=171367

Attachment 308406: Patch

https://bugs.webkit.org/attachment.cgi?id=308406&action=review




--- Comment #7 from Andy Estes <aestes at apple.com> ---
Comment on attachment 308406
  --> https://bugs.webkit.org/attachment.cgi?id=308406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308406&action=review

> Source/WebCore/page/SessionID.cpp:35
> +static bool generationProtectionEnabled = false;

No need for the = false.

> Source/WebCore/page/SessionID.h:90
> +    return sessionID.isValid();

Is an invalid sessionID really an decoding failure? Does something stop us from
encoding invalid values?