[webkit-reviews] review granted: [Bug 171365] Update NetworkStorageSession to support multiple persistent sessions and explicitly set cookie storages : [Attachment 308395] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 171365: Update NetworkStorageSession to support multiple persistent
sessions and explicitly set cookie storages
https://bugs.webkit.org/show_bug.cgi?id=171365

Attachment 308395: Patch

https://bugs.webkit.org/attachment.cgi?id=308395&action=review




--- Comment #7 from Andy Estes <aestes at apple.com> ---
Comment on attachment 308395
  --> https://bugs.webkit.org/attachment.cgi?id=308395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308395&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:65
> +    auto sharedCookieStorage =
adoptCF(_CFHTTPCookieStorageGetDefault(kCFAllocatorDefault));

Over IRC we confirmed that what _CFHTTPCookieStorageGetDefault() returns
shouldn't be adopted.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:72
> +NetworkStorageSession::NetworkStorageSession(SessionID sessionID,
RetainPtr<CFURLStorageSessionRef> platformSession,
RetainPtr<CFHTTPCookieStorageRef> platformCookieStorage)

These RetainPtrs could probably be rvalue references.