[webkit-reviews] review denied: [Bug 171367] Refactor SessionID to support multiple non-ephemeral (persistent) sessions : [Attachment 308352] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 27 00:40:24 PDT 2017

Alex Christensen <achristensen at apple.com> has denied Brady Eidson
<beidson at apple.com>'s request for review:
Bug 171367: Refactor SessionID to support multiple non-ephemeral (persistent)

Attachment 308352: Patch


--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 308352
  --> https://bugs.webkit.org/attachment.cgi?id=308352

View in context: https://bugs.webkit.org/attachment.cgi?id=308352&action=review

> Source/WebCore/page/SessionID.cpp:37
> +static uint64_t currentPersistentID = 1;

I don't think this will work.  Other processes will also need to be able to
tell whether this session is ephemeral or not, and their static variables won't
be synchronized.  We should probably make a SessionID a wrapper around a bool
and a uint64_t.

More information about the webkit-reviews mailing list