[webkit-reviews] review granted: [Bug 171320] WebItemProviderPasteboard should fetch preloaded assets from disk when possible : [Attachment 308235] First pass

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 171320: WebItemProviderPasteboard should fetch preloaded assets from disk
when possible
https://bugs.webkit.org/show_bug.cgi?id=171320

Attachment 308235: First pass

https://bugs.webkit.org/attachment.cgi?id=308235&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 308235
  --> https://bugs.webkit.org/attachment.cgi?id=308235
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=308235&action=review

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:182
> +    RetainPtr<NSArray> _typeToFileURLMaps;

What's with all these NSArrays? (no need to fix in this patch though)

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:294
> +	   // We've already loaded data relevant for this UTI type into disk,
so there's no need to ask the UIItemProvider for the same data again.

into disk? onto disk?

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:295
> +	   if (NSData *result = [NSData
dataWithContentsOfURL:typeToFileURLMap[loadedType]
options:NSDataReadingMappedAlways error:nil])

Should we go with Always or IfSafe?