[webkit-reviews] review granted: [Bug 171293] webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running : [Attachment 308273] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 171293: webkitpy: Teardown iOS Simulators on exit if managed Simulators are
still running
https://bugs.webkit.org/show_bug.cgi?id=171293

Attachment 308273: Patch

https://bugs.webkit.org/attachment.cgi?id=308273&action=review




--- Comment #5 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 308273
  --> https://bugs.webkit.org/attachment.cgi?id=308273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308273&action=review

looks good to me.

> Tools/ChangeLog:9
> +	   thrown while booting.  Make some IOSSimulatorPort functions into
static methods and register

Nit: two spaces.

> Tools/Scripts/webkitpy/port/ios_simulator.py:221
>	       self._createSimulatorApps()

unrelated, but we can consider removing _createSimulatorApps() and moving its
code here. We don't need two methods _create_simulators() and
_createSimulatorApps().