[webkit-reviews] review denied: [Bug 171140] [iOS] REGRESSION (r209409): getBoundingClientRect is wrong for fixed-position elements in resize/orientationchange : [Attachment 308144] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<thorton at apple.com>'s request for review:
Bug 171140: [iOS] REGRESSION (r209409): getBoundingClientRect is wrong for
fixed-position elements in resize/orientationchange
https://bugs.webkit.org/show_bug.cgi?id=171140

Attachment 308144: Patch

https://bugs.webkit.org/attachment.cgi?id=308144&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 308144
  --> https://bugs.webkit.org/attachment.cgi?id=308144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308144&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2994
> +	  
frameView.setLayoutViewportOverrideRect(LayoutRect(fixedPositionLayoutRect));

This is wrong, because fixedPositionLayoutRect comes from
frameView.viewportConstrainedObjectsRect(), which is for the old-style fixed
behavior, not the visual viewport behavior. We need to get this rect from
_page->computeCustomFixedPositionRect().