[webkit-reviews] review granted: [Bug 171316] Encoded filename should be decoded for WKContentExtension.identifier : [Attachment 308223] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 26 10:06:12 PDT 2017
Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 171316: Encoded filename should be decoded for
WKContentExtension.identifier
https://bugs.webkit.org/show_bug.cgi?id=171316
Attachment 308223: Patch
https://bugs.webkit.org/attachment.cgi?id=308223&action=review
--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 308223
--> https://bugs.webkit.org/attachment.cgi?id=308223
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=308223&action=review
> Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp:387
> + auto contentExtension = createExtension(identifier, metaData,
fileData);
> + completionHandler(WTFMove(contentExtension), { });
I don't think you need a local variable for contentExtension.
More information about the webkit-reviews
mailing list