[webkit-reviews] review granted: [Bug 171294] Move mediaCaptureEnabled from WKWebViewConfiguration to WKPreferences : [Attachment 308159] proposed patch v3.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 20:14:41 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Andrew Gold
<agold at apple.com>'s request for review:
Bug 171294: Move mediaCaptureEnabled from WKWebViewConfiguration to
WKPreferences
https://bugs.webkit.org/show_bug.cgi?id=171294

Attachment 308159: proposed patch v3.

https://bugs.webkit.org/attachment.cgi?id=308159&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 308159
  --> https://bugs.webkit.org/attachment.cgi?id=308159
proposed patch v3.

View in context: https://bugs.webkit.org/attachment.cgi?id=308159&action=review

> Source/WebKit2/UIProcess/UserMediaProcessManager.cpp:-121
> -#if !PLATFORM(IOS)
>	       if (&manager->page() == &pageStartingCapture)
>		   continue;
> -#endif

Did you mean to include this?


More information about the webkit-reviews mailing list