[webkit-reviews] review granted: [Bug 171254] REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field : [Attachment 308167] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 171254: REGRESSION (r214863): Web Inspector: Uncaught Exception when losing
focus from a selector field
https://bugs.webkit.org/show_bug.cgi?id=171254

Attachment 308167: Patch

https://bugs.webkit.org/attachment.cgi?id=308167&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 308167
  --> https://bugs.webkit.org/attachment.cgi?id=308167
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308167&action=review

r=me

> Source/WebInspectorUI/ChangeLog:9
> +	   event.relatedTarget of a blur event contains an element where focus
moved to. When tabbing out

"When tabbing out" is unclear. This makes me think you just pressed tab and
suddenly its null, however the steps to reproduce were Command-Tab. I'd
rephrase:

    The event.relatedTarget of a blur event contains the element where focus
moved to.
    In some cases this can be null, such as if the user leaves the application
window.
    For example Command+Tab to switch to another application.