[webkit-reviews] review granted: [Bug 171287] [WebCrypto] Enhance ways to convert an ECDSA signature binary into DER format : [Attachment 308143] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 171287: [WebCrypto] Enhance ways to convert an ECDSA signature binary into
DER format
https://bugs.webkit.org/show_bug.cgi?id=171287

Attachment 308143: Patch

https://bugs.webkit.org/attachment.cgi?id=308143&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 308143
  --> https://bugs.webkit.org/attachment.cgi?id=308143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308143&action=review

r=me.

> Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:147
> +    // InitialOctet is needed when the first byte of r/s is larger or equal
than 128.

"larger or equal than" -> "greater than or equal to"