[webkit-reviews] review granted: [Bug 171289] Call bmalloc scavenger first when handling a memory pressure event : [Attachment 308158] Updated Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 171289: Call bmalloc scavenger first when handling a memory pressure event
https://bugs.webkit.org/show_bug.cgi?id=171289

Attachment 308158: Updated Patch

https://bugs.webkit.org/attachment.cgi?id=308158&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 308158
  --> https://bugs.webkit.org/attachment.cgi?id=308158
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308158&action=review

r=me

> Source/bmalloc/bmalloc/Heap.cpp:54
> +    auto queue = dispatch_queue_create("WebKit Malloc Memory Pressure
Handler", DISPATCH_QUEUE_CONCURRENT);

It's a very minor point, but this should be DISPATCH_QUEUE_SERIAL, because we
don't intend to handle multiple concurrent pressure events.