[webkit-reviews] review granted: [Bug 171260] WebCore.framework should restrict allowable_clients : [Attachment 308151] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 15:13:52 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 171260: WebCore.framework should restrict allowable_clients
https://bugs.webkit.org/show_bug.cgi?id=171260

Attachment 308151: Updated patch

https://bugs.webkit.org/attachment.cgi?id=308151&action=review




--- Comment #12 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 308151
  --> https://bugs.webkit.org/attachment.cgi?id=308151
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308151&action=review

Looks good to me.

> Source/WebCore/Configurations/WebCore.xcconfig:82
> +OTHER_LDFLAGS_BASE_ios = $(OTHER_LDFLAGS_BASE) -framework CFNetwork
-framework CoreGraphics -framework CoreText -framework Foundation -framework
ImageIO -framework MobileCoreServices -framework OpenGLES -lMobileGestalt
$(WK_IOS_BINCOMPAT_LDFLAGS) -allowable_client WebKit -allowable_client iTunesU
-allowable_client Casablanca -allowable_client Remote -allowable_client TVBooks
-allowable_client DumpRenderTree -allowable_client WebKitTestRunner
-allowable_client TestWebKitAPI;

Could you please add a comment with radar numbers for the ones we expect to
remove eventually?


More information about the webkit-reviews mailing list