[webkit-reviews] review granted: [Bug 171283] Web Inspector: "Space" localized string is not loaded in combined and minified builds : [Attachment 308128] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 171283: Web Inspector: "Space" localized string is not loaded in combined
and minified builds
https://bugs.webkit.org/show_bug.cgi?id=171283

Attachment 308128: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=308128&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 308128
  --> https://bugs.webkit.org/attachment.cgi?id=308128
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=308128&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Resource.js:694
> +	   console.assert(!isNaN(size), "Size should be a valid number.");

This seems unrelated, but whatever.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:1782
> +	       console.assert(breakpointTreeElement, "Missing breakpoint
descendant.", this);

Ditto.