[webkit-reviews] review granted: [Bug 171281] Improve wavy underline rendering : [Attachment 308119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 11:53:01 PDT 2017

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 171281: Improve wavy underline rendering

Attachment 308119: Patch


--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 308119
  --> https://bugs.webkit.org/attachment.cgi?id=308119

View in context: https://bugs.webkit.org/attachment.cgi?id=308119&action=review

I take it, the only real way to regression test this is pixel tests?

> Source/WebCore/style/InlineTextBoxStyle.cpp:93
>      // Distance between decoration's axis and Bezier curve's control points.
>      // The height of the curve is based on this distance. Use a minimum of 6
pixels distance since
>      // the actual curve passes approximately at half of that distance, that
is 3 pixels.
>      // The minimum height of the curve is also approximately 3 pixels.
Increases the curve's height
>      // as strokeThickness increases to make the curve look better.

Is this comment still correct?

More information about the webkit-reviews mailing list