[webkit-reviews] review granted: [Bug 171239] Content-Disposition header filename is ignored when 'download' attribute is specified in HTML : [Attachment 308049] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 09:26:53 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 171239: Content-Disposition header filename is ignored when 'download'
attribute is specified in HTML
https://bugs.webkit.org/show_bug.cgi?id=171239

Attachment 308049: Patch

https://bugs.webkit.org/attachment.cgi?id=308049&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 308049
  --> https://bugs.webkit.org/attachment.cgi?id=308049
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308049&action=review

> Source/WebKit2/UIProcess/Downloads/DownloadProxy.cpp:157
> +#if !USE(NETWORK_SESSION)

Then double check that this works with network session, too, before landing. 
EWS runs on El Capitan where we don't use network session


More information about the webkit-reviews mailing list