[webkit-reviews] review granted: [Bug 171256] Resource Load Statistics: Clear network process cache when clearing store : [Attachment 308041] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 171256: Resource Load Statistics: Clear network process cache when clearing
store
https://bugs.webkit.org/show_bug.cgi?id=171256

Attachment 308041: Patch

https://bugs.webkit.org/attachment.cgi?id=308041&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 308041
  --> https://bugs.webkit.org/attachment.cgi?id=308041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308041&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:156
> +    if (clearFirst)

This might have been better named "resetDomain" or something (the 'FIRST' made
me think it was a choice between clearing right at the start, versus cleaning
it later on).

But I don't feel strongly about this, and I'm not convinced renaming it would
be any clearer.