[webkit-reviews] review denied: [Bug 171060] REGRESSION (r215469): [ios-simulator-wk2] LayoutTest compositing/animation/animation-backing.html is a flaky failure : [Attachment 307968] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 171060: REGRESSION (r215469): [ios-simulator-wk2] LayoutTest
compositing/animation/animation-backing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=171060

Attachment 307968: patch

https://bugs.webkit.org/attachment.cgi?id=307968&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 307968
  --> https://bugs.webkit.org/attachment.cgi?id=307968
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307968&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:961
> +    bool hasAcceleratedTransformAnimation =
renderer().animation().isRunningAcceleratedAnimationOnRenderer(renderer(),
CSSPropertyTransform, AnimationBase::Running | AnimationBase::Paused);
> +   
m_graphicsLayer->setHasAcceleratedTransformAnimation(hasAcceleratedTransformAni
mation);
> +    if (!hasAcceleratedTransformAnimation)

I don't think you need to set this from outside of GraphicsLayer(CA).
GraphicsLayerCA::isRunningTransformAnimation() knows this, and
GraphicsLayerCA::updateAnimations() can set or clear the state.