[webkit-reviews] review granted: [Bug 171241] Unhandled enumeration values in IntlDateTimeFormat.cpp : [Attachment 308100] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 25 08:14:23 PDT 2017

JF Bastien <jfbastien at apple.com> has granted Andy VanWagoner
<thetalecrafter at gmail.com>'s request for review:
Bug 171241: Unhandled enumeration values in IntlDateTimeFormat.cpp

Attachment 308100: Patch


--- Comment #7 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 308100
  --> https://bugs.webkit.org/attachment.cgi?id=308100

Looks good. The problem I had in mind is actually kindof a non-problem now that
I think about it: if the enum's underlying type change (say from uint8_t to
uint16_t) then the mangled name of ICU functions which pass that enum in/out
would change.

So I think what you had before was OK in that it would fall through to
"literal", but adding the cases by number works too because it classifies the
values properly.


More information about the webkit-reviews mailing list