[webkit-reviews] review granted: [Bug 171270] [GTK] Add libgpg-error, libgcrypt libraries to JHBuild : [Attachment 308098] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 171270: [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
https://bugs.webkit.org/show_bug.cgi?id=171270

Attachment 308098: Patch

https://bugs.webkit.org/attachment.cgi?id=308098&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 308098
  --> https://bugs.webkit.org/attachment.cgi?id=308098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308098&action=review

> Tools/ChangeLog:20
> +2017-04-25  Zan Dobersek  <zdobersek at igalia.com>
> +
> +	   [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
> +	   https://bugs.webkit.org/show_bug.cgi?id=171270
> +
> +	   Reviewed by NOBODY (OOPS!).

Remove this duplicate changelog entry!

> Tools/gtk/jhbuild.modules:621
> +    <dependencies>
> +	 <dep package="libgpg-error"/>
> +    </dependencies>

Style: put the branch tag first, then the dependencies tag next.

> Tools/gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch:12
> ++  // Enforce the use of /dev/urandom for testing of the libgcrypt-based
> ++  // Web Crypto implementation testing in WebKit.
> ++  // DO NOT USE THIS PATCH OUTSIDE OF TESTING ENVIRONMENTS.
> ++  level = 0;

Nice!