[webkit-reviews] review granted: [Bug 171253] Web Inspector: Open the new bug page in the new tab : [Attachment 308020] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 19:06:50 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 171253: Web Inspector: Open the new bug page in the new tab
https://bugs.webkit.org/show_bug.cgi?id=171253

Attachment 308020: Patch

https://bugs.webkit.org/attachment.cgi?id=308020&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 308020
  --> https://bugs.webkit.org/attachment.cgi?id=308020
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308020&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +	   (sheetElement.innerHTML.div):
> +	  
(let.dismissOptionHTML.loadCompleted.string_appeared_here.dt.A.frivolous.except
ion.will.not.stop.me.dt.dd.a):

Err, these ChangeLog lines don't look right. Better to remove them when they
look like this.


More information about the webkit-reviews mailing list