[webkit-reviews] review denied: [Bug 140713] [WK2] willDestroyGlobalObjectForDOMWindowExtension callback which registered in injectedBundle is not called while WebPage is being closed : [Attachment 245248] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 19:04:57 PDT 2017


Brady Eidson <beidson at apple.com> has denied Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 140713: [WK2] willDestroyGlobalObjectForDOMWindowExtension callback which
registered in injectedBundle is not called while WebPage is being closed
https://bugs.webkit.org/show_bug.cgi?id=140713

Attachment 245248: Patch

https://bugs.webkit.org/attachment.cgi?id=245248&action=review




--- Comment #10 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 245248
  --> https://bugs.webkit.org/attachment.cgi?id=245248
Patch

This patch has been pending review since 2015 with no recent activity.
It seems unlikely that it would even still apply to trunk in its current form.

(Also it hasn't been updated for Darin's feedback)

Clearing from the review queue.

Feel free to update and resubmit if the patch is still relevant.


More information about the webkit-reviews mailing list