[webkit-reviews] review granted: [Bug 171190] test262: test262/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js : [Attachment 307923] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 171190: test262:
test262/test/language/expressions/object/method-definition/early-errors-object-
method-duplicate-parameters.js
https://bugs.webkit.org/show_bug.cgi?id=171190

Attachment 307923: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307923&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307923
  --> https://bugs.webkit.org/attachment.cgi?id=307923
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307923&action=review

r=me

> JSTests/stress/async-await-syntax.js:143
> +    testSyntaxError(`var outerObject = { async method(a, a) {} }`);
> +    testSyntaxError(`var outerObject = { async ['meth' + 'od'](a, a) {} }`);
> +    testSyntaxError(`var outerObject = { async 'method'(a, a) {} }`);
> +    testSyntaxError(`var outerObject = { async 0(a, a) {} }`);

Can you also add some tests that use destructuring and the rest parameter?

> LayoutTests/js/script-tests/parser-syntax-check.js:887
> +invalid("({ foo(a,a){} });");
> +invalid("({ foo(b, c, b){} });");
> +invalid("({ *foo(a,a){} });");
> +invalid("({ *foo(b, c, b){} });");
> +invalid("({ async foo(a,a){} });");
> +invalid("({ async foo(b, c, b){} });");
> +valid("({ foo: function(a,a){} });");
> +valid("({ foo: function(b, c, b){} });");
> +valid("({ foo: function*(a,a){} });");
> +valid("({ foo: function*(b, c, b){} });");
> +valid("({ foo: async function(a,a){} });");
> +valid("({ foo: async function(b, c, b){} });");

Can you also add some tests that use destructuring and the rest parameter?