[webkit-reviews] review granted: [Bug 171057] [JSC] Use JSFixedArray directly when using call_varargs : [Attachment 307908] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 12:33:29 PDT 2017


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 171057: [JSC] Use JSFixedArray directly when using call_varargs
https://bugs.webkit.org/show_bug.cgi?id=171057

Attachment 307908: Patch

https://bugs.webkit.org/attachment.cgi?id=307908&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307908
  --> https://bugs.webkit.org/attachment.cgi?id=307908
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307908&action=review

nice. r=me.
I think once we implement a more sophisticated analysis to transform code into
this, it'll be nice to have this support in the FTL.

> Source/JavaScriptCore/ChangeLog:12
> +	   to oit new_array_with_spread. This is very simple and effective
because this

typo: oit => emit


More information about the webkit-reviews mailing list