[webkit-reviews] review granted: [Bug 170897] test262: test262/test/language/computed-property-names/class/static/getter-prototype.js : [Attachment 307698] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 170897: test262:
test262/test/language/computed-property-names/class/static/getter-prototype.js
https://bugs.webkit.org/show_bug.cgi?id=170897

Attachment 307698: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307698&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307698
  --> https://bugs.webkit.org/attachment.cgi?id=307698
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307698&action=review

r=me

>> Source/JavaScriptCore/runtime/JSObject.cpp:1710
>> +	return defineOwnProperty(this, exec, propertyName, descriptor, true);
> 
> Like this. Out of context I have no clue that this is about throwing. In
fact, the definition is super unhelpful also:
>   typedef bool (*DefineOwnPropertyFunctionPtr)(JSObject*, ExecState*,
PropertyName, const PropertyDescriptor&, bool);
> !!!

Agreed. We really need to move to an enum here at some point.