[webkit-reviews] review granted: [Bug 171211] Image decoders must have private constructors to avoid refcount misuse: ASSERTION FAILED: m_deletionHasBegun when destroying ImageDecoder : [Attachment 307975] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted  review:
Bug 171211: Image decoders must have private constructors to avoid refcount
misuse: ASSERTION FAILED: m_deletionHasBegun when destroying ImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=171211

Attachment 307975: Patch

https://bugs.webkit.org/attachment.cgi?id=307975&action=review




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 307975
  --> https://bugs.webkit.org/attachment.cgi?id=307975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307975&action=review

>>> Source/WebCore/platform/image-decoders/ImageDecoder.cpp:149
>>> +	     return nullptr;
>> 
>> This should never happen, I think we should return the default and make this
return a Ref<>
> 
> What do you mean by "return the default"... is there a default image decoder?
I would do RELEASE_ASSERT_NOT_REACHED().

Oops, sorry I meant remove the default