[webkit-reviews] review denied: [Bug 170899] [selectors4] :focus-within should use the flat tree : [Attachment 307364] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 170899: [selectors4] :focus-within should use the flat tree
https://bugs.webkit.org/show_bug.cgi?id=170899

Attachment 307364: Patch

https://bugs.webkit.org/attachment.cgi?id=307364&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 307364
  --> https://bugs.webkit.org/attachment.cgi?id=307364
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307364&action=review

>> Source/WebCore/dom/Element.cpp:614
>> +	for (Element* element = this; element; element =
downcast<Element>(element->parentInComposedTree()))
> 
> Isn't parentElementInComposedTree what we should use here ?

Yeah, the cast is not safe. parentInComposedTree can return ShadowRoot which is
not Element.