[webkit-reviews] review granted: [Bug 171197] test262: test262/test/built-ins/Number/prototype/toPrecision/nan.js : [Attachment 307937] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 171197: test262: test262/test/built-ins/Number/prototype/toPrecision/nan.js
https://bugs.webkit.org/show_bug.cgi?id=171197

Attachment 307937: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307937&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307937
  --> https://bugs.webkit.org/attachment.cgi?id=307937
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307937&action=review

r=me

> Source/JavaScriptCore/runtime/NumberPrototype.cpp:404
> +    RETURN_IF_EXCEPTION(scope, encodedJSValue());

style nit: We've been doing: `RETURN_IF_EXCEPTION(scope, { });` in most places.