[webkit-reviews] review granted: [Bug 171162] [JSC] Get stack pointer without pthread attr : [Attachment 307912] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 171162: [JSC] Get stack pointer without pthread attr
https://bugs.webkit.org/show_bug.cgi?id=171162

Attachment 307912: Patch

https://bugs.webkit.org/attachment.cgi?id=307912&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 307912
  --> https://bugs.webkit.org/attachment.cgi?id=307912
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307912&action=review

r=me with fixes.

> Source/WTF/wtf/ThreadingPthreads.cpp:115
> +    int ret = sigaltstack(nullptr, &stack);

typo: /sigaltstack/signaltstack/

> Source/WTF/wtf/ThreadingPthreads.cpp:136
> +    ASSERT_WITH_MESSAGE(!isOnAlternativeSignalStack(), "Do not support
alternative signal stack. Consider disabling concurrent GC.");

Let's change the message to "Using an alternative signal stack is not
supported. Consider disabling the concurrent GC."

Also, I suggest making this a RELEASE_ASSERT.  I think this code is not
performance critical, and this failure is critical and may be hard to detect if
not asserted.