[webkit-reviews] review granted: [Bug 171146] [MediaCapture] Improvements to CoreAudioCaptureSource : [Attachment 307837] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 171146: [MediaCapture] Improvements to CoreAudioCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=171146

Attachment 307837: Patch

https://bugs.webkit.org/attachment.cgi?id=307837&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 307837
  --> https://bugs.webkit.org/attachment.cgi?id=307837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307837&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:402
> +    uint32_t propertySize = sizeof(m_captureDeviceID);

Does this work in a 32-bit build?

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:550
> +    m_currentSettings = std::nullopt;

This should call the base class method so it notifies observers.