[webkit-reviews] review granted: [Bug 171145] Rename callerDOMWindow()/CallerDocument to incumbentDOMWindow()/IncumbentDocument : [Attachment 307816] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 171145: Rename callerDOMWindow()/CallerDocument to
incumbentDOMWindow()/IncumbentDocument
https://bugs.webkit.org/show_bug.cgi?id=171145

Attachment 307816: Patch

https://bugs.webkit.org/attachment.cgi?id=307816&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307816
  --> https://bugs.webkit.org/attachment.cgi?id=307816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307816&action=review

r=me

> Source/WebCore/bindings/js/JSDOMWindowBase.cpp:291
> +DOMWindow& incumbentDOMWindow(ExecState* exec)

IMO, I think it could be helpful to have a comment here either linking to the
spec, or describing the heart of what this function does.
Just by reading its name, it wouldn't be obvious to me. I understand what it's
called incumbent, since this isn't always
the caller (setTimeout, etc), but I think it's "caller" in spirit.