[webkit-reviews] review granted: [Bug 171132] Regression(r206240): XMLSerializer.serializeToString() does not properly escape '<' / '>' in attribute values : [Attachment 307777] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171132: Regression(r206240): XMLSerializer.serializeToString() does not
properly escape '<' / '>' in attribute values
https://bugs.webkit.org/show_bug.cgi?id=171132

Attachment 307777: Patch

https://bugs.webkit.org/attachment.cgi?id=307777&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 307777
  --> https://bugs.webkit.org/attachment.cgi?id=307777
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307777&action=review

> Source/WebCore/ChangeLog:9
> +	   Test: fast/dom/XMLSerializer-serializeToString-entities.html

This line should appear after [1] followed by a blank line before the first
per-line comment appears.

> Source/WebCore/editing/MarkupAccumulator.cpp:217
> -void MarkupAccumulator::appendAttributeValue(StringBuilder& result, const
String& attribute, bool documentIsHTML)
> +void MarkupAccumulator::appendAttributeValue(StringBuilder& result, const
String& attribute, bool isHTMLSerialization)

I would have called this isSerializingHTML or simply isHTML instead.
Better, we could have changed this boolean to enum named
MarkupSerializationMode or something.