[webkit-reviews] review granted: [Bug 171101] Refactor MASM probe to allow printing of custom types. : [Attachment 307769] updated patch w/ JF's feedback applied.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 171101: Refactor MASM probe to allow printing of custom types.
https://bugs.webkit.org/show_bug.cgi?id=171101

Attachment 307769: updated patch w/ JF's feedback applied.

https://bugs.webkit.org/attachment.cgi?id=307769&action=review




--- Comment #8 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 307769
  --> https://bugs.webkit.org/attachment.cgi?id=307769
updated patch w/ JF's feedback applied.

View in context: https://bugs.webkit.org/attachment.cgi?id=307769&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerPrinter.h:117
> +    explicit Memory(RegisterID& reg, size_t bytes, DumpStyle style =
GenericDump)

FWIW I only meant for the single-parameter ctors. This is fine though:
pre-C++11 it didn't mean anything, but now it applies the same rules for
initialization with curlies.