[webkit-reviews] review granted: [Bug 171076] Split cryptographic digest computation and parsing out of CSP code so it can be reused : [Attachment 307647] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 171076: Split cryptographic digest computation and parsing out of CSP code
so it can be reused
https://bugs.webkit.org/show_bug.cgi?id=171076

Attachment 307647: Patch

https://bugs.webkit.org/attachment.cgi?id=307647&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 307647
  --> https://bugs.webkit.org/attachment.cgi?id=307647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307647&action=review

r=me

> Source/WTF/wtf/text/Base64.h:154
> +WTF_EXPORT_PRIVATE bool base64Decode(const StringView&,
SignedOrUnsignedCharVectorAdapter, unsigned options = Base64Default);

We usually take StringView in parameter, rather than const StringView& I
believe.

> Source/WTF/wtf/text/Base64.h:192
> +WTF_EXPORT_PRIVATE bool base64URLDecode(const StringView&,
SignedOrUnsignedCharVectorAdapter);

ditto.