[webkit-reviews] review denied: [Bug 171128] Regression(r204605): text on http://www1.odn.ne.jp/pasto_cbe26550/ looks garbled : [Attachment 307771] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171128: Regression(r204605): text on http://www1.odn.ne.jp/pasto_cbe26550/
looks garbled
https://bugs.webkit.org/show_bug.cgi?id=171128

Attachment 307771: Patch

https://bugs.webkit.org/attachment.cgi?id=307771&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 307771
  --> https://bugs.webkit.org/attachment.cgi?id=307771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307771&action=review

> Source/WebCore/platform/text/TextCodecICU.cpp:96
> +DECLARE_ALIASES(windows_949, "euc-kr", "cseuckr", "csksc56011987",
"iso-ir-149", "korean", "ks_c_5601-1987", "ks_c_5601-1989", "ksc5601",
"ksc_5601", "ms949", "x-KSC5601", "x-windows-949", "x-uhc", "cp949");

This won't work - cp949 is a different encoding in ICU than CFString thinks it
is.

I don't see why we would add support for non-standard encoding aliases here.
Why not just special case them in defaultTextEncodingNameForSystemLanguage()?
That's the only place where they should be supported, not in Web content.