[webkit-reviews] review granted: [Bug 171124] Make AudioSampleBufferList::reset() less expensive. : [Attachment 307757] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 21 11:31:36 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 171124: Make AudioSampleBufferList::reset() less expensive.
https://bugs.webkit.org/show_bug.cgi?id=171124

Attachment 307757: Patch

https://bugs.webkit.org/attachment.cgi?id=307757&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 307757
  --> https://bugs.webkit.org/attachment.cgi?id=307757
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307757&action=review

> Source/WebCore/platform/audio/WebAudioBufferList.cpp:45
> +    m_pristineList =
std::unique_ptr<AudioBufferList>(static_cast<AudioBufferList*>(::operator new
(m_listBufferSize)));

Nit: maybe m_canonicalList?


More information about the webkit-reviews mailing list