[webkit-reviews] review granted: [Bug 167343] webkit-gtk-2.15.3 fails to build on macOS due to missing declaration of U8_MAX_LENGTH : [Attachment 307733] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 167343: webkit-gtk-2.15.3 fails to build on macOS due to missing
declaration of U8_MAX_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=167343

Attachment 307733: Patch

https://bugs.webkit.org/attachment.cgi?id=307733&action=review




--- Comment #17 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 307733
  --> https://bugs.webkit.org/attachment.cgi?id=307733
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307733&action=review

Wow.

Please rename the bug to match the changelog title.

> Source/WTF/ChangeLog:10
> +	   implicitly without copying directory lists around. This matches
exisiting

exisiting -> existing

> Source/WTF/ChangeLog:11
> +	   practise for all targets except WTF, headers from which are always
included

practise -> practice, unless you want to go full British