[webkit-reviews] review denied: [Bug 171112] [GTK] Expose the ENABLE_SUBTLE_CRYPTO CMake option, have it depend on libgcrypt 1.7.0 : [Attachment 307729] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 171112: [GTK] Expose the ENABLE_SUBTLE_CRYPTO CMake option, have it depend
on libgcrypt 1.7.0
https://bugs.webkit.org/show_bug.cgi?id=171112

Attachment 307729: Patch

https://bugs.webkit.org/attachment.cgi?id=307729&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 307729
  --> https://bugs.webkit.org/attachment.cgi?id=307729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307729&action=review

I think this should be renamed to ENABLE_WEB_CRYPTO before it's made public.

> Source/cmake/OptionsGTK.cmake:142
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SUBTLE_CRYPTO PUBLIC OFF)

Not ready to turn it ON yet?

I think we should make it public in the same patch that we turn it ON. The
point of making it public is to provide users a way to turn it off if they
don't have new enough libgcrypt. If it's not ON by default, then no point in
making it public yet.