[webkit-reviews] review granted: [Bug 171103] [GCrypt] ECDSA signing and verification support : [Attachment 307705] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 171103: [GCrypt] ECDSA signing and verification support
https://bugs.webkit.org/show_bug.cgi?id=171103

Attachment 307705: Patch

https://bugs.webkit.org/attachment.cgi?id=307705&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 307705
  --> https://bugs.webkit.org/attachment.cgi?id=307705
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307705&action=review

Doesn't this fix any test currently skipped?

> Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:79
> +std::optional<Vector<uint8_t>> mpiData(gcry_sexp_t paramSexp)

should this be static?