[webkit-reviews] review requested: [Bug 170897] test262: test262/test/language/computed-property-names/class/static/getter-prototype.js : [Attachment 307698] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 20 23:27:13 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 170897: test262:
test262/test/language/computed-property-names/class/static/getter-prototype.js
https://bugs.webkit.org/show_bug.cgi?id=170897

Attachment 307698: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307698&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 307698

  --> https://bugs.webkit.org/attachment.cgi?id=307698&action=review

[PATCH] Proposed Fix

Improved patch.

We actually continue down the same code path:

    op_put_getter_by_val
      => JSObject::putGetter
	=> defineOwnProperty
	  => validateAndApplyPropertyDescriptor

Previously we were muting the exception, now we throw it.


More information about the webkit-reviews mailing list